USHIFT-6765: Add automatic restart and approval options to Claud prow-PR script by ggiguash · Pull Request #6428 · openshift/microshift

ggiguash · 2026-03-30T05:30:09Z

Scope

Approve PRs only if all the tests finished successfully
Restart failed jobs only

Testing

Approve: see this PR and this comment
Restart: see this PR and this comment

openshift-ci · 2026-03-30T05:30:15Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-03-30T05:30:15Z

@ggiguash: This pull request references USHIFT-6765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Approvel PRs only if all the tests finished successfully

Restart failed jobs only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-30T05:30:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5454f6e4-cae7-439a-85fd-3419b83ad395

📥 Commits

Reviewing files that changed from the base of the PR and between de33f09 and f01bd79.

📒 Files selected for processing (1)

.claude/scripts/microshift-prow-jobs-for-pull-requests.sh

🚧 Files skipped from review as they are similar to previous changes (1)

.claude/scripts/microshift-prow-jobs-for-pull-requests.sh

Walkthrough

Adds two new CLI modes to the Prow job management script: approve posts approval comments when all discovered jobs are SUCCESS; restart posts /test … rerun commands for jobs with result FAILURE. fetch_pr_results() now fails when job discovery or any job-result fetch fails, and PRs with incomplete results are skipped.

Changes

Cohort / File(s)	Summary
Prow jobs PR utility `.claude/scripts/microshift-prow-jobs-for-pull-requests.sh`	Added `mode_approve()` and `mode_restart()` modes and updated `usage()`; `fetch_pr_results()` now signals non-zero and writes a `.fetch_failed` marker when job listing or any job result fetch fails; control flow updated to skip PRs with incomplete results; `mode_approve` posts `/lgtm` and `/verified by ci` only when all discovered jobs are `SUCCESS`; `mode_restart` gathers jobs with result `FAILURE`, reads each failed job's `prowjob.json` from GCS to extract rerun commands, and posts one `/test …` line per failed job.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-30T05:32:19Z

@ggiguash: This pull request references USHIFT-6765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Scope

Approvel PRs only if all the tests finished successfully

Restart failed jobs only

Testing

Restart: see this PR and this comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ggiguash · 2026-03-30T05:33:49Z

@coderabbitai perform full review

coderabbitai · 2026-03-30T05:34:00Z

@ggiguash: On it! Performing a full review of the PR now.

✅ Actions performed

Full review triggered.

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.claude/scripts/microshift-prow-jobs-for-pull-requests.sh:
- Around line 291-301: The script appends "/test ${short_name}" to the comment
even when short_name is empty, creating malformed commands; update the loop that
builds comment (the block using short_name and comment variables where
short_name is populated from jq and sed) to skip adding a `/test` line when
short_name is empty or only whitespace (e.g., check short_name after trimming
and only append when non-empty), leaving the existing trailing-newline removal
and gh pr comment call unchanged.
- Around line 216-238: The approval logic currently trusts whatever result files
exist in tmpdir, allowing undercounting when fetches fail; update the flow so
fetch_pr_results communicates failures (e.g., return non-zero or write a failure
marker) and the caller checks that before counting results: call
fetch_pr_results "${pr_number}" "${tmpdir}" and if it exits non-zero or a
fetch-failed marker exists, log "PR #${pr_number}: incomplete job results,
skipping" and continue instead of computing total/success; ensure the variables
and checks around tmpdir, total, success, and the loop that reads files are only
executed when fetch_pr_results succeeded.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1a04f11e-884a-482c-88f8-2166e4619f81

📥 Commits

Reviewing files that changed from the base of the PR and between bad0cfb and de33f09.

📒 Files selected for processing (1)

.claude/scripts/microshift-prow-jobs-for-pull-requests.sh

openshift-ci-robot · 2026-03-30T05:46:19Z

@ggiguash: This pull request references USHIFT-6765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Scope

Approve PRs only if all the tests finished successfully

Restart failed jobs only

Testing

Approve: TBD

Restart: see this PR and this comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-30T06:42:10Z

@ggiguash: This pull request references USHIFT-6765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Scope

Approve PRs only if all the tests finished successfully

Restart failed jobs only

Testing

Approve: see this PR and this comment

Restart: see this PR and this comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ggiguash · 2026-03-30T07:04:45Z

/verified by @ggiguash

openshift-ci-robot · 2026-03-30T07:04:58Z

@ggiguash: This PR has been marked as verified by @ggiguash.

Details

In response to this:

/verified by @ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-30T07:06:41Z

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

eslutsky · 2026-03-30T07:57:06Z

/lgtm

openshift-ci · 2026-03-30T07:57:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [eslutsky,ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ggiguash added 2 commits March 30, 2026 08:10

Add approve mode to prow jobs PR script

27b8356

Add restart mode to prow jobs PR script

de33f09

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026

ggiguash changed the title ~~USHIFT-6765: Add automatic restart and approval options to prow PR script~~ USHIFT-6765: Add automatic restart and approval options to Claud prow-PR script Mar 30, 2026

coderabbitai Bot reviewed Mar 30, 2026

View reviewed changes

Comment thread .claude/scripts/microshift-prow-jobs-for-pull-requests.sh Outdated

Comment thread .claude/scripts/microshift-prow-jobs-for-pull-requests.sh

ggiguash added 2 commits March 30, 2026 09:47

Skip incomplete fetch_pr_results

c967e3f

Skip empty job names when restarting

f01bd79

ggiguash marked this pull request as ready for review March 30, 2026 06:51

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026

openshift-ci Bot requested review from agullon and kasturinarra March 30, 2026 06:51

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 30, 2026

openshift-ci Bot assigned eslutsky Mar 30, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026

openshift-merge-bot Bot merged commit 67116d2 into openshift:main Mar 30, 2026
7 checks passed

ggiguash deleted the analyze-ci-pr-approval branch March 30, 2026 09:00

Conversation

ggiguash commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Testing

Uh oh!

openshift-ci Bot commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci-robot commented Mar 30, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Testing

Uh oh!

ggiguash commented Mar 30, 2026

Uh oh!

coderabbitai Bot commented Mar 30, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 30, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Testing

Uh oh!

openshift-ci-robot commented Mar 30, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Testing

Uh oh!

ggiguash commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

openshift-ci Bot commented Mar 30, 2026

Uh oh!

eslutsky commented Mar 30, 2026

Uh oh!

openshift-ci Bot commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ggiguash commented Mar 30, 2026 •

edited

Loading

openshift-ci-robot commented Mar 30, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Mar 30, 2026 •

edited

Loading

openshift-ci-robot commented Mar 30, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 30, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 30, 2026 •

edited by openshift-ci Bot

Loading